[Windows] Fix positioning for key tester and HID console windows#465
Merged
fauxpark merged 5 commits intoqmk:masterfrom Mar 22, 2024
Merged
[Windows] Fix positioning for key tester and HID console windows#465fauxpark merged 5 commits intoqmk:masterfrom
fauxpark merged 5 commits intoqmk:masterfrom
Conversation
Member
Author
|
The designer changes seem to be mostly reducing verbosity (eg. removing pointless |
Member
It's a codegen'ed file, so it should be fine to basically ignore so long as it "looks close enough". |
tzarc
approved these changes
Mar 20, 2024
Member
tzarc
left a comment
tzarc
left a comment
There was a problem hiding this comment.
Much simpler to review without whitespace. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FormStartPosition.CenterParentdoesn't work unless you show the window withShowDialog(). Since we still want to allow interaction with the main window while they are open we have to useShow()instead and manually callCenterToParent()in the Load event handler.And as usual Visual Studio wanted to move things around in the Designer.cs and resx files...
Types of Changes
Issues Fixed or Closed by This PR