Merged
Conversation
Member
Author
|
Still needs adding to the first-load console output showing what devices are supported. |
Member
Author
|
Tested on both platforms. |
Member
|
GD32VF bootloader contains a bug and reports a page size of 2048 bytes. This is fixed by dfu-util 0.10+. As a precaution the dfu-util version should be checked, otherwise this would result in a bricked keyboard. |
Member
Author
Both platforms are at 0.11 already. |
Member
|
Alright, if there is no way we can have a dfu-util version below that on these this check is unnecessary. |
KarlK90
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for GD32V DFU.
Types of Changes