[macOS] Fix open menu item and recent documents clear behaviour#355
Merged
fauxpark merged 1 commit intoqmk:masterfrom Apr 28, 2022
Merged
[macOS] Fix open menu item and recent documents clear behaviour#355fauxpark merged 1 commit intoqmk:masterfrom
fauxpark merged 1 commit intoqmk:masterfrom
Conversation
nooges
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
File->Open Recent->Cleardid not immediately clear the file path comboboxFile->Openthrew an exception because theopenDocument:method was not implemented - redirected it toopenButtonClick:Types of Changes
Issues Fixed or Closed by This PR
Marking this as fixed because I think the "clear all" approach is better and simpler. Will need to be redone on Windows - there is no inbuilt functionality for it in WinForms.