Skip to content

Comments

[macOS] Logging refactor#340

Merged
fauxpark merged 6 commits intoqmk:masterfrom
fauxpark:log-box-refactor-macos
Apr 15, 2022
Merged

[macOS] Logging refactor#340
fauxpark merged 6 commits intoqmk:masterfrom
fauxpark:log-box-refactor-macos

Conversation

@fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 11, 2022

Description

Sister PR #339

  • Replaced Printing class with new subclass of NSTextView which handles all the logging internally
  • Defined light and dark colour schemes for log box
  • Added some new MessageTypes for more fine-grained display
  • Improved HID report callback to only fire the delegate when a complete line has been received
  • Slight cleanups of pbxproj file

image
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team April 11, 2022 13:05
@fauxpark fauxpark merged commit 0f62767 into qmk:master Apr 15, 2022
@fauxpark fauxpark deleted the log-box-refactor-macos branch April 15, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants