Skip to content

Comments

[Windows] Logging refactor#339

Merged
fauxpark merged 6 commits intoqmk:masterfrom
fauxpark:log-box-refactor
Apr 15, 2022
Merged

[Windows] Logging refactor#339
fauxpark merged 6 commits intoqmk:masterfrom
fauxpark:log-box-refactor

Conversation

@fauxpark
Copy link
Member

Description

  • Replaced Printing class with new subclass of RichTextBox which handles all the logging internally
  • Added some new MessageTypes for more fine-grained display
  • Improved HID report callback to only fire the delegate when a complete line has been received (as the previous behaviour of appending a newline when necessary is no longer viable - all log entries end in a newline)
  • Fixed a small bug when adding newly detected USB devices to the list (apparently I have been running in Release config for a while... VS only started complaining when I noticed)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team April 11, 2022 07:07
@fauxpark fauxpark mentioned this pull request Apr 11, 2022
5 tasks
@fauxpark fauxpark merged commit 5f69785 into qmk:master Apr 15, 2022
@fauxpark fauxpark deleted the log-box-refactor branch April 15, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants