Remove default keymap download section#314
Merged
fauxpark merged 2 commits intoqmk:masterfrom Oct 29, 2021
fauxpark:remove-default-keymap-download-section
Merged
Remove default keymap download section#314fauxpark merged 2 commits intoqmk:masterfrom fauxpark:remove-default-keymap-download-section
fauxpark merged 2 commits intoqmk:masterfrom
fauxpark:remove-default-keymap-download-section
Conversation
drashna
approved these changes
Oct 28, 2021
|
Am I missing something or is this functionality now completely missing (the search bar)? |
Member
Author
|
See the above linked PR. |
|
Could you please guide me to the reasoning? I don’t understand the removal of the search bar. The only things I reasons I can find are related to code quality, which shouldn’t have any influence on decisions like this imo. Maybe I missed something, please let me know if I did |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just removing stuff for now, UI rearrangements will come later.
Types of Changes
Issues Fixed or Closed by This PR