Refactor MCU selection dropdown#306
Merged
fauxpark merged 2 commits intoqmk:masterfrom Oct 6, 2021
fauxpark:mcu-selector-refactor
Merged
Refactor MCU selection dropdown#306fauxpark merged 2 commits intoqmk:masterfrom fauxpark:mcu-selector-refactor
fauxpark merged 2 commits intoqmk:masterfrom
fauxpark:mcu-selector-refactor
Conversation
tzarc
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Most of the related logic is now in its own ComboBox/NSComboBox subclass, and it displays slightly nicer formatted MCU names.
On Windows, instead of writing out mcu-list.txt to a file (which I'm pretty sure happens to all the embedded files on every launch...) we can just read the contents out directly.
Types of Changes
Issues Fixed or Closed by This PR