Conversation
|
Just a heads up, because this touches so many files, this may take more time to review. A separate PR for each board may be easier and get merged in faster. |
|
Yeah sorry about that, they all require the new combo stuff so rather then having 10PRs open and dependant on the userspace/engine stuff and #8120 this seemed like a good option. :( |
micolous
left a comment
micolous
left a comment
There was a problem hiding this comment.
I had a quick look at this trying to build for Ginny – it seems to build OK, but there are some issues (in the review comments).
I notice there's a lot of files here that have the execute bit set that don't need it (eg: keyboards/gboards/k/ginny/config.h, ginny.c, ginny.h, matrix.c, readme.md...)
germ
force-pushed
the
gboards-consolidate
branch
from
88967a9 to
28e5969
Compare
zvecr
left a comment
zvecr
left a comment
There was a problem hiding this comment.
Im going to double down on the "needs separate PRs". As it stands, this PR relocates user keymaps which falls under our current breaking changes definition. Separate PRs allows us to merge your new keyboards now while working out what we can do for the existing boards.
zvecr
added
the
breaking_change
|
Went ahead a broke it up into seperate PRs (referenced above). Closing this for the time being |
4 participants
Updates all g Heavy industries boards to use new features and consolidate them in /keyboards/gboards/
Types of Changes
Issues Fixed or Closed by This PR
Requires #8120 to be merged