Repository navigation
Fix \param names that do not match the declaration - #67239
Merged
Merged
Conversation
troopa81
approved these changes
Sep 1, 2026
Member
|
It misses pre-commit checks (sip) ? |
Contributor
Author
|
None of the six are sipified. Five sit under src/app and src/providers, which have no bindings at all, and qgsmeshcalcnode.h is inside a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ran doxygen over src and six
\paramnames came back with nothing matching them in the declaration below. Most are an argument that got renamed while the comment stayed put, anduseheadersagainstuseheaderpluscategoryagainstcatare off by a letter or two. Doxygen drops a name it cannot match without saying anything, so the argument quietly ends up undocumented on the API page while the build stays green. I left out the hits where the argument list carriesSIP_OUTorSIP_TRANSFER, my reader mangles those, and the ones where the documented parameter is gone from the signature altogether, since removing a line there is someone else's call.AI tool usage
Claude Code (claude-opus-5) found the mismatches and drafted this text. Every one of the six was checked by hand against the declaration under it.