Repository navigation
feat: add optional separate gRPC ingress - #525
Open
inamdarmihir wants to merge 1 commit into
Open
inamdarmihir wants to merge 1 commit into
inamdarmihir wants to merge 1 commit into
Conversation
This was referenced Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
grpcIngressvalues block andtemplates/grpc-ingress.yaml. When enabled, it renders a second Ingress named<fullname>-grpcthat routes to the gRPC service port (6334). It is disabled by default and mirrors the existingingressvalues:ingressClassName,annotations,additionalLabels,hostsandtls.Why
REST and gRPC generally can't share one Ingress. For example, ingress-nginx needs
nginx.ingress.kubernetes.io/backend-protocol: GRPCon a dedicated Ingress. Until now the chart offered no way to expose gRPC separately.How was it tested
helm lint charts/qdrantpasses.helm templatewith default values is byte-identical tomain.ingress.enabled=true,grpcIngress.enabled=trueit renders two Ingresses:qdrantroutes to port 6333 andqdrant-grpcroutes to port 6334 under the gRPC host, with the configured class, annotations and tls.go test ./testpasses, including two new render-level tests: disabled by default, and enabled with class, annotations, hosts and tls.golangci-lint.gofmtis clean.Notes
values.schema.jsononmain. If add values.schema.json for values validation #516 lands first, the newgrpcIngresskeys will need adding to it.httpRoute:block, so the keys don't conflict.backend-protocol: GRPCannotation is left as a commented example invalues.yaml, not set by default.Fixes #402
Authored by Mihir Inamdar.