Skip to content

fix: do not modify payload filters in local mode in-place#1169

Merged
joein merged 1 commit into
devfrom
do-not-modify-dt-conditions-local-mode
Mar 13, 2026
Merged

fix: do not modify payload filters in local mode in-place#1169
joein merged 1 commit into
devfrom
do-not-modify-dt-conditions-local-mode

Conversation

@joein

@joein joein commented Mar 13, 2026

Copy link
Copy Markdown
Member

@netlify

netlify Bot commented Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 9e2a61d
🔍 Latest deploy log https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/69b3ec443e39600008e6c04c
😎 Deploy Preview https://deploy-preview-1169--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joein joein mentioned this pull request Mar 13, 2026
Closed
@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8aa6cfbd-25b1-4848-968f-393470d01669

📥 Commits

Reviewing files that changed from the base of the PR and between 0a69a4c and 9e2a61d.

📒 Files selected for processing (1)
  • qdrant_client/local/payload_filters.py
📝 Walkthrough

Walkthrough

The check_datetime_range function in payload_filters.py was refactored to replace in-place mutations of the input condition object with local temporary variables. Instead of directly modifying condition.lt, condition.lte, condition.gt, and condition.gte, the function now computes these values as local variables via make_condition_tz_aware and uses them directly in the boolean expression. The evaluation semantics remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: refactoring check_datetime_range to avoid in-place mutation of payload filter conditions.
Description check ✅ Passed The description references issue #1163, which is related to the changeset about not modifying payload filters in-place.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch do-not-modify-dt-conditions-local-mode
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@joein joein requested a review from tbung March 13, 2026 13:04
@joein joein merged commit 57e6952 into dev Mar 13, 2026
12 checks passed
joein added a commit that referenced this pull request Mar 13, 2026
@joein @jnMetaCode
fix: do not modify payload filters in local mode in-place (#1169)
a410b9d 
Co-authored-by: JiangNan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbung tbung Awaiting requested review from tbung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joein