qdrant_client/uploader/grpc_uploader.py (1)

3-3: ⚠️ Potential issue | 🟠 Major

Use Optional[grpc.UpdateMode] instead of the bare grpc.UpdateMode annotation

grpc.UpdateMode = None correctly avoids the TypeError from the old protobuf _UpdateModeEnumTypeWrapper metaclass not supporting the | operator, but it is semantically wrong — the annotation claims the parameter is grpc.UpdateMode (non-nullable) while the default is None. This will cause static type checkers to flag every call site that passes None (including the call in process_upload at line 149).

typing.Optional[T] is the backward-compatible way to express the same intent without invoking __or__ at runtime and without losing type accuracy.

🔧 Proposed fix

-from typing import Any, Generator, Iterable
+from typing import Any, Generator, Iterable, Optional

-    update_mode: grpc.UpdateMode = None,
+    update_mode: Optional[grpc.UpdateMode] = None,

Also applies to: 24-24

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@qdrant_client/uploader/grpc_uploader.py` at line 3, The parameter annotations
using grpc.UpdateMode with a default of None are wrong; change those to
typing.Optional[grpc.UpdateMode] wherever a default None is used (e.g., the
function/method signatures in grpc_uploader.py that currently annotate
update_mode: grpc.UpdateMode = None) so the type is nullable and static type
checkers won't error; update all occurrences (including the call site in
process_upload) to use Optional[grpc.UpdateMode] and ensure typing.Optional is
imported or referenced as Optional from typing.