Skip to content

new: adjust numpy versioning#1132

Merged
joein merged 1 commit into
devfrom
numpy-versioning
Dec 4, 2025
Merged

new: adjust numpy versioning#1132
joein merged 1 commit into
devfrom
numpy-versioning

Conversation

@joein

@joein joein commented Dec 2, 2025

Copy link
Copy Markdown
Member

numpy dropped support for python3.10 as of 2.3.0, in the same release it introduced support for python3.14

@netlify

netlify Bot commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 3590a8d
🔍 Latest deploy log https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/692ebde0722c5d00089a51e9
😎 Deploy Preview https://deploy-preview-1132--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joein joein requested a review from tbung December 2, 2025 10:22
@coderabbitai

coderabbitai Bot commented Dec 2, 2025

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This change updates the numpy dependency constraints in pyproject.toml to support additional Python versions, specifically 3.13 and 3.14. The existing entry for numpy >=2.1.0 with Python >=3.13 is replaced with expanded entries that specify more granular version combinations across Python 3.10 through 3.14. The modifications add numpy >=2.3.0 for Python >=3.14 and reorganize constraints to cover intermediate Python versions with appropriate numpy version ranges.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify numpy version constraint mappings are correct for each Python version range (3.10–3.14)
  • Confirm no gaps or overlaps exist between the new constraint entries
  • Validate that numpy version compatibility aligns with Python version requirements across all entries

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'adjust numpy versioning' directly relates to the main change of updating numpy dependency constraints in pyproject.toml based on Python version support changes.
Description check ✅ Passed The description explains the reason for the numpy version adjustments, specifically that numpy 2.3.0 dropped Python 3.10 support and added Python 3.14 support, which aligns with the dependency changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch numpy-versioning
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1de2ce2 and 3590a8d.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Redirect rules - poetic-froyo-8baba7
  • GitHub Check: Header rules - poetic-froyo-8baba7
  • GitHub Check: Pages changed - poetic-froyo-8baba7
  • GitHub Check: Python 3.12.x on ubuntu-latest test
  • GitHub Check: Python 3.13.x on ubuntu-latest test
  • GitHub Check: Python 3.10.x on ubuntu-latest test
  • GitHub Check: Python 3.9.x on ubuntu-latest test
  • GitHub Check: Python 3.11.x on ubuntu-latest test
🔇 Additional comments (1)
pyproject.toml (1)

18-25: Numpy versioning constraints are correct and well-aligned with numpy's version support.

NumPy 2.3.0 supports Python 3.11–3.13 (and Python 3.14 will be supported when released), while NumPy 2.1.0 supports Python 3.10–3.13. Your changes properly partition the support across Python versions:

  • Python 3.10 gets numpy <2.3.0 (preventing use of 2.3.0+ which dropped 3.10 support)
  • Python 3.11–3.13 allows flexible numpy versions appropriate for each
  • Python 3.14+ requires numpy ≥2.3.0 (for 3.14 support)

The constraint for Python 3.13 (line 23) correctly allows numpy ≥2.1.0 without an upper bound, since numpy 2.3.0 still supports 3.13 despite dropping 3.10.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joein joein merged commit 20cc45f into dev Dec 4, 2025
14 of 24 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Dec 4, 2025
Merged
joein added a commit that referenced this pull request Dec 12, 2025
@joein
new: adjust numpy versioning (#1132)
2c45a53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbung tbung tbung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joein @tbung