Fix indexed integer range filter with float values#9054
Merged
Conversation
JojiiOfficial
approved these changes
May 15, 2026
agourlay
approved these changes
May 15, 2026
generall
pushed a commit
that referenced
this pull request
May 22, 2026
* Add test, assert integer range bounds work properly on float fractionals * Use special float range conversion, respect integer bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9049
A numeric range filter with float values behaves inconsistent when having an integer index. A range filter with
gte: 1.5would still match a value of1.Note this only affects filters when an integer index is created. If having a float index, or having no index at all, behavior is sound.
This adds a test to assert behavior. I've added a function for converting a float range into an integer range respecting integer bounds.
All Submissions:
devbranch (notmaster) and my branch was created fromdev.Changes to Core Features: