Introduce default update timeout#8944
Merged
Merged
Conversation
Member
|
Related: actix/actix-web#3462 |
timvisee
approved these changes
May 7, 2026
generall
approved these changes
May 7, 2026
timvisee
pushed a commit
that referenced
this pull request
May 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default the update timeout for REST and gRPC user requests to the inter-node request_timeout (60s) when the client doesn't supply one, so a vanished client can't leave the wait phase running forever.
Why
Actix-web doesn't cancel handler futures on client disconnect, and Qdrant has no server-side cap on the update wait when ?timeout= is omitted.
Without a default, a disconnected client leaves await_update_result and the deferred-points loop hanging until the operation completes naturally.
Change
In src/common/update.rs::update() (the choke point all do_*_points helpers funnel through), fall back to toc.get_channel_service().request_timeout() when params.timeout is None.
Internal maintenance callers (clean.rs, sharding_keys.rs, resharding cleanup, update_all_local) bypass this function and call ShardReplicaSet::update_local directly, so they keep None = wait forever for long-running operations like index creation.