We dont actually need .worker_threads in search runtime#8756
Merged
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Apr 22, 2026
| let num_threads = common::defaults::search_thread_count(max_search_threads); | ||
| runtime::Builder::new_multi_thread() | ||
| .worker_threads(num_threads) | ||
| .worker_threads(2.min(num_threads)) // 2 because of paranoia margin |
Member
There was a problem hiding this comment.
In my opinion we should set this to zero, but it appears that Tokio doesn't allow that and panics.
I therefore vote to fully replace this Tokio runtime with a threadpool that is sync-only. That way we prevent accidental misuse and eliminate potential foot guns. We can do that in a separate PR.
Member
Author
There was a problem hiding this comment.
I have some things to try with semafors, I am not sure we want something like Rayon here, as we don't want to pre-allocate all threads.
Member
There was a problem hiding this comment.
No, a proper dynamic thread pool that fits our use case 👍
timvisee
pushed a commit
that referenced
this pull request
May 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.