Fix empty sparse vector name validation#8194
Merged
Merged
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Apr 10, 2026
Member
timvisee
left a comment
timvisee
left a comment
There was a problem hiding this comment.
Thanks!
Normally I'd consider this as breaking change since we're enforcing extra limits here. But I see behavior with this vector name was broken before anyway, which makes it reasonable to expect nobody is using it like this.
Here's a place we enforce this already:
qdrant/lib/segment/src/data_types/vectors.rs
Line 568 in ee7baa6
In documentation we also state this:
Unlike dense vectors, sparse vectors must be named.
Thank you for the test as well.
timvisee
pushed a commit
that referenced
this pull request
May 8, 2026
* Fix empty sparse vector name validation * Reorder validation to check empty sparse name before duplicate name --------- Co-authored-by: leohenon <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5209.
Block empty sparse vector names on collection creation.
Adds a regression test.
Does not migrate existing invalid configs.