Remove unnecessary clone() calls from refactored update worker#7704
Closed
Copilot wants to merge 2 commits intorefactor-update-workersfrom
Closed
Remove unnecessary clone() calls from refactored update worker#7704Copilot wants to merge 2 commits intorefactor-update-workersfrom
Copilot wants to merge 2 commits intorefactor-update-workersfrom
Conversation
Co-authored-by: generall <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor worker files for better organization
Remove unnecessary clone() calls from refactored update worker
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
devbranch. Did you create your branch fromdev?Changes to Core Features:
The refactoring PR introduced explicit
.clone()calls inupdate_worker_internalthat weren't in the original code, changing Arc reference counting behavior from move semantics to clone-on-pass.Fixed:
.clone()onupdate_operation_lockandupdate_trackerparametersCollectionUpdater::update()Before:
After:
All moved functions now preserve original logic. Visibility changes and
Self::qualifications remain correct for cross-module access.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.