Skip to content

refactor update workers#7642

Merged
generall merged 5 commits intodevfrom
refactor-update-workers
Dec 8, 2025
Merged

refactor update workers#7642
generall merged 5 commits intodevfrom
refactor-update-workers

Conversation

@generall
Copy link
Copy Markdown
Member

  • refactor: move flush workers into a dedicated file
  • move optimizer worker into a dedicated file
  • move update worker into a dedicated file

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@qdrant qdrant deleted a comment from coderabbitai Bot Dec 1, 2025
@timvisee timvisee self-requested a review December 1, 2025 17:42
@generall generall force-pushed the refactor-update-workers branch from eae601e to 9332d25 Compare December 1, 2025 19:54
coderabbitai[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@generall these changes are still compatible with #7640 being merged, right?

It is not trivial to see if all moved functions are still 100% the same.

@qdrant qdrant deleted a comment from coderabbitai Bot Dec 2, 2025
@generall generall force-pushed the refactor-update-workers branch from 9332d25 to b77c3c9 Compare December 6, 2025 01:47
@generall
Copy link
Copy Markdown
Member Author

generall commented Dec 6, 2025

@copilot please check that moved functions do not contain any changes in the logic. This PR is intended for refactoring only

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 6, 2025

@generall I've opened a new pull request, #7704, to work on those changes. Once the pull request is ready, I'll request review from you.

coderabbitai[bot]

This comment was marked as outdated.

@qdrant qdrant deleted a comment from coderabbitai Bot Dec 6, 2025
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
coderabbitai[bot]

This comment was marked as resolved.

@qdrant qdrant deleted a comment from coderabbitai Bot Dec 6, 2025
@qdrant qdrant deleted a comment from coderabbitai Bot Dec 8, 2025
@generall generall merged commit 6fe46d0 into dev Dec 8, 2025
15 checks passed
@generall generall deleted the refactor-update-workers branch December 8, 2025 10:51
timvisee pushed a commit that referenced this pull request Dec 18, 2025
* refactor: move flush workers into a dedicated file

fmt

* move optimizer worker into a dedicated file

* move update worker into a dedicated file

* Update lib/collection/src/update_workers/optimization_worker.rs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update lib/collection/src/update_workers/optimization_worker.rs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants