[cluster telemetry] internal service types#7599
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
coszio
force-pushed
the
grpc-types-for-peer-telemetry
branch
from
9b662d4 to
bcf2900
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| message GetPeerTelemetryResponse { | ||
| reserved 1; // id | ||
| reserved 2; // app | ||
| map<string, CollectionTelemetry> collections = 3; // Mapping from collection name to its telemetry | ||
| ClusterTelemetry cluster = 4; // Telemetry about the cluster and peers | ||
| reserved 5; // requests | ||
| reserved 6; // memory | ||
| reserved 7; // hardware | ||
| } |
There was a problem hiding this comment.
So this basically follows the same structure as our existing telemetry, but it is very limited.
Is there a strong argument for doing it this way, versus implementing a whole new kind of telemetry with it's own fields?
There was a problem hiding this comment.
Yes, and it is made to replicate it closely.
We already have the information we need from existing telemetry, so we can reuse the collectors we already have for internal service.
* stripped down grpc types for peer telemetry * return err instead of panic * use correct definitions * improve types
2 participants
As a first step towards aggregating telemetry from all peers, we need to be able to communicate telemetry with other peers. This can only be done through the internal service.
This PR adds internal service types for mapping current telemetry into internal service. For now, we include only info about the peer, resharding, and shard transfers.