Skip to content

rename common -> qdrant_common to avoid name with other python packages#7571

Merged
generall merged 1 commit into
devfrom
avoid-common-proto-name
Nov 21, 2025
Merged

rename common -> qdrant_common to avoid name with other python packages#7571
generall merged 1 commit into
devfrom
avoid-common-proto-name

Conversation

@generall

Copy link
Copy Markdown
Member

@generall generall requested review from Anush008 and joein November 20, 2025 12:13
@generall

Copy link
Copy Markdown
Member Author

@Anush008 could you please check that it doesn't break java client?

@Anush008 Anush008 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All imports and tests continue to work like before.
qdrant/java-client#91

@joein joein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xzfc

xzfc commented Nov 21, 2025

Copy link
Copy Markdown
Member

So such file name turns to be quite common, amirite?


We have package qdrant;, so the idiomatic approach would be to put all files in a qdrant/ subdirectory, and import it like this:

import "qdrant/common.proto";
import "qdrant/collections.proto";

See how Google organizes it: https://github.com/googleapis/googleapis/blob/ded7ed1e4cce7c165c56a417572cebea9bc1d82c/google/bigtable/v2/bigtable.proto
Also see https://buf.build/docs/reference/protobuf-files-and-packages/#file-paths

@qdrant qdrant deleted a comment from coderabbitai Bot Nov 21, 2025
@generall

Copy link
Copy Markdown
Member Author

so the idiomatic approach would be to put all files in a qdrant/ subdirectory, and import it like this:

I am afraid it will unpredictable break some clients.

@generall generall merged commit 59ee168 into dev Nov 21, 2025
16 checks passed
@generall generall deleted the avoid-common-proto-name branch November 21, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants