Skip to content

Adjust log warning about trying to read lock a segment#7556

Merged
timvisee merged 2 commits into
devfrom
fix-log-try-read-lock-a-segment
Nov 18, 2025
Merged

Adjust log warning about trying to read lock a segment#7556
timvisee merged 2 commits into
devfrom
fix-log-try-read-lock-a-segment

Conversation

@timvisee

@timvisee timvisee commented Nov 18, 2025

Copy link
Copy Markdown
Member

The log message is wrong. It only tries to lock a single segment, not all of them.

I'd be nice to add a bit more context about the exact segment, but I don't see a good way of doing this without passing extra context into the function.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@timvisee timvisee requested review from agourlay and ffuugoo November 18, 2025 10:31
@timvisee timvisee marked this pull request as ready for review November 18, 2025 10:31
@timvisee timvisee changed the title Fix log warning about trying to read lock a segment Adjust log warning about trying to read lock a segment Nov 18, 2025
coderabbitai[bot]

This comment was marked as resolved.

Comment thread lib/shard/src/segment_holder/mod.rs Outdated
Co-authored-by: Roman Titov <[email protected]>
@qdrant qdrant deleted a comment from coderabbitai Bot Nov 18, 2025
@qdrant qdrant deleted a comment from coderabbitai Bot Nov 18, 2025
@timvisee timvisee merged commit 986a55a into dev Nov 18, 2025
16 checks passed
@timvisee timvisee deleted the fix-log-try-read-lock-a-segment branch November 18, 2025 11:40
timvisee added a commit that referenced this pull request Nov 25, 2025
* Fix log warning about trying to read lock a segment

* Fix typo

Co-authored-by: Roman Titov <[email protected]>

---------

Co-authored-by: Roman Titov <[email protected]>
@timvisee timvisee mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants