lib/edge/python/src/types/point_vectors.rs (1)

9-23: New PyPointVectors wrapper — good; add Python signature for discoverability.

Constructor is clean and infallible. Add an explicit Python signature for help() output.

 #[pymethods]
 impl PyPointVectors {
-    #[new]
+    #[new]
+    #[pyo3(text_signature = "(id, vector)")]
     pub fn new(id: PyPointId, vector: PyVector) -> Self {
         Self(PointVectorsPersisted {
             id: PointIdType::from(id),
             vector: VectorStructPersisted::from(vector),
         })
     }
 }

lib/edge/python/src/update.rs (3)

34-51: Param naming consistency: use “filter” instead of “condition”.

All other constructors use filter. Rename for a consistent Python API.

-    pub fn upsert_points_conditional(points: Vec<PyPoint>, condition: PyFilter) -> Self {
+    pub fn upsert_points_conditional(points: Vec<PyPoint>, filter: PyFilter) -> Self {
         let points = points.into_iter().map(PointStructPersisted::from).collect();
         let points_op = PointInsertOperationsInternal::PointsList(points);

-        let condition = Filter::from(condition);
+        let condition = Filter::from(filter);

---

133-157: Add text_signature for Python help() across constructors.

Many methods expose non-obvious arg orders. Add #[pyo3(text_signature = "...")] for parity with existing payload methods.

Examples:

 #[staticmethod]
+#[pyo3(text_signature = "(points)")]
 pub fn upsert_points(points: Vec<PyPoint>) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(points, filter)")]
 pub fn upsert_points_conditional(points: Vec<PyPoint>, filter: PyFilter) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(ids)")]
 pub fn delete_points(ids: Vec<PyPointId>) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(filter)")]
 pub fn delete_points_by_filter(filter: PyFilter) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(point_vectors)")]
 pub fn update_vectors(point_vectors: Vec<PyPointVectors>) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(point_vectors, filter)")]
 pub fn update_vectors_conditional(point_vectors: Vec<PyPointVectors>, filter: PyFilter) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(ids, vector_names)")]
 pub fn delete_vectors(ids: Vec<PyPointId>, vector_names: Vec<String>) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(filter, vector_names)")]
 pub fn delete_vectors_by_filter(filter: PyFilter, vector_names: Vec<String>) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(ids)")]
 pub fn clear_payload(ids: Vec<PyPointId>) -> Self { ... }

 #[staticmethod]
+#[pyo3(text_signature = "(filter)")]
 pub fn clear_payload_by_filter(filter: PyFilter) -> Self { ... }

Also applies to: 159-182, 184-202, 204-221, 242-266, 268-291

---

143-147: Error message can include parse failure detail for JsonPath.

Currently raises the key string only. Prefer the parser’s error to aid debugging.

-    .map(|k| JsonPath::from_str(&k).map_err(|_| PyErr::new::<PyValueError, _>(k)))
+    .map(|k| JsonPath::from_str(&k)
+        .map_err(|e| PyErr::new::<PyValueError, _>(format!("invalid json path '{}': {}", k, e))))

Also applies to: 169-172, 189-193, 209-212, 252-255, 279-281

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro