tests/e2e_tests/test_data_compatibility.py (3)

15-31: Annotate class attributes with ClassVar for clarity.

Class-level constants should be annotated with typing.ClassVar to distinguish them from instance attributes and align with PEP 526 best practices.

Apply this diff:

+from typing import ClassVar
+
 class TestStorageCompatibility:
     """Test storage and snapshot compatibility with defined previous Qdrant versions."""
     
-    PREV_PATCH_VERSION = "v1.14.1"
-    PREV_MINOR_VERSION = "v1.15.4"
+    PREV_PATCH_VERSION: ClassVar[str] = "v1.14.1"
+    PREV_MINOR_VERSION: ClassVar[str] = "v1.15.4"
     
-    EXPECTED_COLLECTIONS = [
+    EXPECTED_COLLECTIONS: ClassVar[list[str]] = [
         "test_collection_vector_memory",
         "test_collection_vector_on_disk", 
         "test_collection_vector_on_disk_threshold",

---

110-126: Prefix unused fixture parameters with underscore.

The docker_client and qdrant_image parameters are required for the pytest fixture dependency graph but unused directly in the test. Following pytest convention, prefix them with an underscore to signal intentional non-use.

Apply this diff:

     @pytest.mark.parametrize("version", [PREV_PATCH_VERSION, PREV_MINOR_VERSION])
-    def test_storage_compatibility(self, docker_client, qdrant_image, temp_storage_dir, version, qdrant_container_factory):
+    def test_storage_compatibility(self, _docker_client, _qdrant_image, temp_storage_dir, version, qdrant_container_factory):
         """Test storage compatibility with previous versions."""

---

128-150: Prefix unused fixture parameters with underscore.

Same as the storage compatibility test - docker_client and qdrant_image are fixture dependencies but unused directly.

Apply this diff:

     @pytest.mark.parametrize("version", [PREV_PATCH_VERSION, PREV_MINOR_VERSION])
-    def test_snapshot_compatibility(self, docker_client, qdrant_image, temp_storage_dir, version, qdrant_container_factory):
+    def test_snapshot_compatibility(self, _docker_client, _qdrant_image, temp_storage_dir, version, qdrant_container_factory):
         """Test snapshot recovery compatibility with previous versions."""

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

tests/e2e_tests/test_data_compatibility.py (2)

18-31: Use immutable tuple for collection names.

The EXPECTED_COLLECTIONS attribute is a mutable list used as a constant. Use a tuple for immutability and clarity, or annotate with ClassVar if it must remain a list.

Apply this diff:

-    EXPECTED_COLLECTIONS = [
+    EXPECTED_COLLECTIONS = (
         "test_collection_vector_memory",
         "test_collection_vector_on_disk", 
         "test_collection_vector_on_disk_threshold",
         "test_collection_scalar_int8",
         "test_collection_product_x64",
         "test_collection_product_x32", 
         "test_collection_product_x16",
         "test_collection_product_x8",
         "test_collection_binary",
         "test_collection_mmap_field_index",
         "test_collection_vector_datatype_u8",
         "test_collection_vector_datatype_f16"
-    ]
+    )

---

84-88: Consider more specific exception handling.

The broad Exception catch may hide unexpected errors. Consider catching more specific exceptions from ClientUtils.list_collections_names() or allowing unexpected errors to propagate for better debugging.

For example:

     try:
         collections = client.list_collections_names()
-    except Exception as e:
+    except (ConnectionError, TimeoutError) as e:
         print(f"Error listing collections: {e}")
         return False

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

tests/e2e_tests/test_data_compatibility.py (1)

18-31: Consider annotating mutable class attributes with ClassVar.

For clarity and to satisfy static analysis, class-level mutable collections should be annotated with typing.ClassVar.

Apply this diff:

+from typing import ClassVar
+
 class TestStorageCompatibility:
     """Test storage and snapshot compatibility with defined previous Qdrant versions."""
     
     PREV_PATCH_VERSION = "v1.14.1"
     PREV_MINOR_VERSION = "v1.15.4"
     
-    EXPECTED_COLLECTIONS = [
+    EXPECTED_COLLECTIONS: ClassVar[list[str]] = [
         "test_collection_vector_memory",
         "test_collection_vector_on_disk", 
         "test_collection_vector_on_disk_threshold",
         "test_collection_scalar_int8",
         "test_collection_product_x64",
         "test_collection_product_x32", 
         "test_collection_product_x16",
         "test_collection_product_x8",
         "test_collection_binary",
         "test_collection_mmap_field_index",
         "test_collection_vector_datatype_u8",
         "test_collection_vector_datatype_f16"
     ]

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

tests/e2e_tests/test_data_compatibility.py (3)

18-31: Annotate class attributes with ClassVar to satisfy Ruff (RUF012) and intent.

These are constants; mark them as ClassVar and add typing import.

@@
-from pathlib import Path
+from pathlib import Path
+from typing import ClassVar, List
@@
 class TestStorageCompatibility:
@@
-    PREV_PATCH_VERSION = "v1.14.0"
-    PREV_MINOR_VERSION = "v1.15.4"
+    PREV_PATCH_VERSION: ClassVar[str] = "v1.14.0"
+    PREV_MINOR_VERSION: ClassVar[str] = "v1.15.4"
@@
-    EXPECTED_COLLECTIONS = [
+    EXPECTED_COLLECTIONS: ClassVar[List[str]] = [
         "test_collection_vector_memory",
         "test_collection_vector_on_disk", 
         "test_collection_vector_on_disk_threshold",
         "test_collection_scalar_int8",
         "test_collection_product_x64",
         "test_collection_product_x32", 
         "test_collection_product_x16",
         "test_collection_product_x8",
         "test_collection_binary",
         "test_collection_mmap_field_index",
         "test_collection_vector_datatype_u8",
         "test_collection_vector_datatype_f16"
     ]

---

110-110: Remove unused fixture parameters (ARG002).

docker_client and qdrant_image are dependencies of qdrant_container_factory; they don’t need to be in the test signature.

-def test_storage_compatibility(self, docker_client, qdrant_image, temp_storage_dir, version, qdrant_container_factory):
+def test_storage_compatibility(self, temp_storage_dir, version, qdrant_container_factory):
@@
-def test_snapshot_compatibility(self, docker_client, qdrant_image, temp_storage_dir, version, qdrant_container_factory):
+def test_snapshot_compatibility(self, temp_storage_dir, version, qdrant_container_factory):

Also applies to: 129-129

---

122-123: Increase server wait to reduce flakiness on heavy datasets/snapshots.

30s can be tight; bump to 90–120s.

-        if not client.wait_for_server():
+        if not client.wait_for_server(timeout=90):
             pytest.fail(f"Server failed to start for {version}")
@@
-        if not client.wait_for_server():
+        if not client.wait_for_server(timeout=120):
             pytest.fail(f"Server failed to start from snapshot for {version}")

Also applies to: 146-147

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro