Only implement verification for CollectionQuery types#6319
Merged
coszio merged 3 commits intostrict-mode-for-formulasfrom Apr 4, 2025
Merged
Conversation
coszio
added a commit
that referenced
this pull request
Apr 4, 2025
* verify CollectionQuery's Prefetch * remove implementation for REST query * remove implementation for REST query groups
coszio
added a commit
that referenced
this pull request
Apr 4, 2025
* move problems.rs to collection crate * change type on datetime_key expression * extract from expression * check for unindexed fields in formula * clippy * dedup code * Only implement verification for `CollectionQuery` types (#6319) * verify CollectionQuery's Prefetch * remove implementation for REST query * remove implementation for REST query groups * add basic openapi test
pull Bot
pushed a commit
to kp-forks/qdrant
that referenced
this pull request
Apr 21, 2025
…t#6317) * move problems.rs to collection crate * change type on datetime_key expression * extract from expression * check for unindexed fields in formula * clippy * dedup code * Only implement verification for `CollectionQuery` types (qdrant#6319) * verify CollectionQuery's Prefetch * remove implementation for REST query * remove implementation for REST query groups * add basic openapi test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there was duplication in the implementation of
StrictModeVerificationtrait for query request types.We already have a converging type for rest and grpc for query requests, so we can implement the trait only for this converging type.
By unifying, this also fixes a hole where we were not checking the prefetches when using the grpc interface.