Suggestions for global feature flags#6198
Merged
timvisee merged 1 commit intoglobal-feature-flagsfrom Mar 19, 2025
Merged
Conversation
6 tasks
timvisee
added a commit
that referenced
this pull request
Mar 19, 2025
* Add global feature flags structure, load on start * Feature flag use of new shard key format * Enable feature flag for new shard key format by default in dev builds * Prevent unwrapping everywhere; Single place for initialization (#6198) * Disable shard key feature flag by default for now, it causes problems --------- Co-authored-by: Jojii <[email protected]>
timvisee
added a commit
that referenced
this pull request
Mar 21, 2025
* Add global feature flags structure, load on start * Feature flag use of new shard key format * Enable feature flag for new shard key format by default in dev builds * Prevent unwrapping everywhere; Single place for initialization (#6198) * Disable shard key feature flag by default for now, it causes problems --------- Co-authored-by: Jojii <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor suggestions for global feature flags in #6194:
This is just a suggestion and I'm happy to discuss or discard if not needed!