Merged
Conversation
18 tasks
timvisee
force-pushed
the
mutable-id-tracker-truncate-partial-mapping
branch
from
40c187d to
0ba670f
Compare
timvisee
force-pushed
the
mutable-id-tracker-integration
branch
3 times, most recently
from
8abbf31 to
fda7c08
Compare
Base automatically changed from
mutable-id-tracker-truncate-partial-mapping
to
dev
March 19, 2025 09:39
timvisee
force-pushed
the
mutable-id-tracker-integration
branch
from
fda7c08 to
6909926
Compare
This comment was marked as resolved.
This comment was marked as resolved.
timvisee
force-pushed
the
mutable-id-tracker-integration
branch
from
6909926 to
1f10060
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
generall
approved these changes
Mar 19, 2025
Member
generall
left a comment
generall
left a comment
There was a problem hiding this comment.
Did some manual tests to check that id_tracked doesn't grow indefinitelly:
- upsert points in a loop with overwrite
- create and delete the same point 1k times
In both cases files either don't grow (because we re-use same internal id), or optimizer kicks-in and vacuums the segment.
So works as expected.
One unpleasant side-effect: if new id tracker is recovered in old version, which doesn't know about it, it will be treated as if there are no points in segment, rather than a panic. (might be possible to address in separate PR)
This was referenced Mar 19, 2025
timvisee
added a commit
that referenced
this pull request
Mar 21, 2025
* Rename mutable ID tracker mappings file * Make new ID tracker the default, add new variant for RocksDB tracker * In mutable ID tracker, only list files if they exist on disk * Don't use the new mutable ID tracker yet * Feature flag usage of new mutable ID tracker * Simplify RocksDB check a bit * Rename both the mutable ID tracker files
This was referenced Mar 21, 2025
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked in: #6157
Depends on: #6173
Add support for the new mutable ID tracker.
It is currently locked behind a feature flag, only enabled in development builds. In the next Qdrant release the new tracker will enabled globally.
RocksDB based tracker is used by default, unless new mappings are stored on disk
New tracker is used by default, unless there are RocksDB mappings on disk
Set
QDRANT__FEATURE_FLAGS__USE_MUTABLE_ID_TRACKER_WITHOUT_ROCKSDB=trueto prematurely enable the new ID tracker.Tasks
devAll Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?