Enable mmap storage using blob store for sparse vectors by default#5784
Merged
Enable mmap storage using blob store for sparse vectors by default#5784
Conversation
timvisee
commented
Jan 13, 2025
Comment on lines
983
to
991
| pub enum SparseVectorStorageType { | ||
| /// Storage on disk | ||
| // (rocksdb storage) | ||
| #[default] | ||
| OnDisk, | ||
| /// Storage in memory maps | ||
| // (blob_store storage) | ||
| #[default] | ||
| Mmap, | ||
| } |
Member
Author
There was a problem hiding this comment.
Note: this also changes the default variant on SparseVectorStorageType, I expect no weird side effects because of it.
Member
Do we push sparse vectors on chaos testing? |
Member
Author
We don't right now. But we do in continuous benchmarks. |
agourlay
approved these changes
Jan 13, 2025
generall
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for the release of Qdrant 1.13 and enable the mmap storage for sparse vectors using blob store by default. This allows us to test it on chaos testing for some time.
All Submissions:
devbranch. Did you create your branch fromdev?