Skip to content

Enable mmap storage using blob store for payloads by default#5783

Merged
timvisee merged 2 commits intodevfrom
blob-store-payload-enable
Jan 13, 2025
Merged

Enable mmap storage using blob store for payloads by default#5783
timvisee merged 2 commits intodevfrom
blob-store-payload-enable

Conversation

@timvisee
Copy link
Copy Markdown
Member

@timvisee timvisee commented Jan 13, 2025

Prepare for the release of Qdrant 1.13 and enable the mmap storage for payloads using blob store by default. This allows us to test it on chaos testing for some time.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@timvisee timvisee requested review from agourlay and generall January 13, 2025 12:54
@github-actions github-actions Bot mentioned this pull request Jan 13, 2025
Closed
@timvisee timvisee force-pushed the blob-store-payload-enable branch from 2be8f70 to ea727ad Compare January 13, 2025 13:49
@timvisee timvisee mentioned this pull request Jan 13, 2025
Open
@agourlay
Copy link
Copy Markdown
Member

agourlay commented Jan 13, 2025 •
edited
Loading

Looks like tests/consensus_tests/test_strict_mode.py::test_payload_strict_mode_upsert_no_local_shard requires a manual change.
I'll have a quick look at it to unblock this :)

@timvisee
Copy link
Copy Markdown
Member Author

timvisee commented Jan 13, 2025

Thanks for the manual patch! Missed those during my change.

Since all looks good I'm merging now.

@timvisee timvisee merged commit a69ddff into dev Jan 13, 2025
@timvisee timvisee deleted the blob-store-payload-enable branch January 13, 2025 16:45
timvisee added a commit that referenced this pull request Jan 16, 2025
@timvisee @agourlay
Enable mmap storage using blob store for payloads by default (#5783)
d0fced4 
* Enable mmap storage using blob store for payloads by default

* adapt test for new mmap payload storage

---------

Co-authored-by: Arnaud Gourlay <[email protected]>
@timvisee timvisee mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agourlay agourlay agourlay approved these changes

@generall generall generall approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timvisee @agourlay @generall