Conversation
agourlay
reviewed
Dec 16, 2024
| ("DeletePoints.collection_name", "length(min = 1, max = 255)"), | ||
| ("UpdatePointVectors.collection_name", "length(min = 1, max = 255)"), | ||
| ("UpdatePointVectors.vectors", "custom(function = \"crate::grpc::validate::validate_named_vectors_not_empty\", message = \"must specify vectors to update\")"), | ||
| ("UpdatePointVectors.points", ""), |
Member
There was a problem hiding this comment.
What?! The build script does not fail on non existing field?
Member
Author
There was a problem hiding this comment.
Sadly not. It's a limitation in the code generator of tonic/prost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In gRPC we had a lot of custom validation rules because earlier validator versions had limited support for numbers wrapped in options.
Since #4894 we can use the built-in range and length validators on numbers wrapped in options.
I've removed the custom validation functions we now don't need anymore to greatly simplify validation in gRPC.
All Submissions:
devbranch. Did you create your branch fromdev?