Repository navigation
fix(edge-py): keep MatchValue(True) a boolean instead of 1 - #11324
inamdarmihir wants to merge 1 commit into
Conversation
PyValueVariants tried to extract an integer before a boolean. A Python bool is a subclass of int, so True became 1 and False became 0, and a filter on a boolean payload field matched nothing. Try Bool before Integer. Extracting a bool is strict, so a plain int is still taken as an integer. Add an example, run by the existing py-examples job, that asserts the value round-trips and filters match. Fixes qdrant#10846 Authored by Mihir
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: preserving MatchValue(True) as a boolean instead of converting it to 1. Linked Issues check Issue #10846requires boolean MatchValue values to remain booleans, boolean payload filters to match, and integer matching to remain correct.PyValueVariants::extractnow triesBoolbefore `Intege…Out of Scope Changes check The pull request changes only MatchValue extraction and adds a focused example for the affected boolean, integer, and string filter behavior. These changes directly support issue #10846.Description check The description states the problem (MatchValue(value=True).value returns 1 in qdrant-edge-py, so boolean payload filters match nothing), names the cause (Integer is tried before Bool in PyValueVariant… Full details: Linked Issues check
-
Explanation
Issue
#10846requires boolean MatchValue values to remain booleans, boolean payload filters to match, and integer matching to remain correct.PyValueVariants::extractnow triesBoolbeforeInteger, while strict boolean extraction preserves plain integer handling. The newmatch_value_types.pyexample asserts boolean round-trips and checks boolean, integer, and string filters.
Full details: Description check
-
Explanation
The description states the problem (MatchValue(value=True).value returns 1 in qdrant-edge-py, so boolean payload filters match nothing), names the cause (Integer is tried before Bool in PyValueVariants::extract, and bool subclasses int), and lists the change (Bool tried first in match.rs, plus a new example run by py-examples). It also gives build, reproduction, and test results. It is directly related to the changeset, so it passes.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Fixes #10846.
Problem
In
qdrant-edge-py,MatchValue(value=True).valuereturned1, so a filter on a boolean payload field matched nothing.PyValueVariants::extracttriedIntegerbeforeBool. A Pythonboolis a subclass ofint, soTrueextracted as an integer.Change
BoolbeforeIntegerinlib/edge/python/src/types/filter/match.rs. Extracting aboolis strict, so a plainintis still taken as an integer.PyValueintypes/value.rsalready orders its variants this way.examples/match_value_types.py, which the existingpy-examplesjob runs. It asserts thatTrue/Falseround-trip and that string, integer and boolean filters each match.Testing
maturin develop --no-default-features --features abi3and ran the reproduction from the issue:likes == Truereturned 0 points before the change and 1 after.AssertionError) and passes with the fix.cargo fmt --check -p qdrant-edge-pyis clean.cargo clippy -D warningsrun here: it stops on existingunnecessary_as_slicelints inlib/sparse, which this change doesn't touch.AI disclosure
Commits:
Prompt, summarized from the instructions given to the AI tool: fix #10846, where
MatchValue(value=True).valueis1inqdrant-edge-pyand boolean filters match nothing. Find the cause inlib/edge/python/src/types/filter/match.rs, keep the change to that file plus a regression example run by the existingpy-examplesjob, build the bindings with maturin, reproduce the issue first, and confirm the new example fails on the old code.I reviewed the result and can answer questions about it.
Authored by Mihir