Skip to content

Add iteration count and time in trying to read lock log line - #10542

Merged
timvisee merged 1 commit into
devfrom
report-try-read-lock-iteration-count
Sep 9, 2026
Merged

timvisee merged 1 commit into
devfrom
report-try-read-lock-iteration-count

Conversation

@timvisee

@timvisee timvisee commented Sep 8, 2026

Copy link
Copy Markdown
Member

Instrument for support cases, add iteration count and wait time to the following log line:

Trying to read-lock a segment is taking a long time. This could be a deadlock and may block new updates. (waited: 10s, iteration: #20)

When I spot this log line it usually does not come alone. Many appear. The line does not tell us whether it's one task waiting for a very very long time, or whether it's many tasks waiting a bit more than 10 seconds that still resolve. It's an important distinction to differentiate a contended versus a dead-locked cluster.

By adding the iteration count and wait time we can see the difference.

Alternatively I could add an UUID where each loop iteration reports the same UUID, but having an iteration counter and wait time is more convenient.

All Submissions:

  • My PR targets the dev branch (not master) and my branch was created from dev.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@timvisee
timvisee requested review from agourlay and coszio September 8, 2026 16:35
@qdrant qdrant deleted a comment from coderabbitai Bot Sep 9, 2026
@timvisee
timvisee merged commit a6c9891 into dev Sep 9, 2026
17 checks passed
@timvisee
timvisee deleted the report-try-read-lock-iteration-count branch September 9, 2026 09:06
@timvisee timvisee mentioned this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants