GPRC validation seems to be incorrect in the latest release. OptimizersConfigDiff.deleted_threshold", "range(min = 1.0)"), makes it so that the min val of deleted threshold is 1, however in reality the value is between 0 -> 1. This is confirmed by the code in the commit before the grpc validation change.
Current Behavior
Was discovered when I tried to migrate using the qdrant_client.migrate.migrate module with a grpc client as target and got the following error
debug_error_string = "UNKNOWN:Error received from peer {created_time:"2025-01-15T01:32:28.115958603-08:00", grpc_status:3, grpc_message:"Validation error in body: [optimizers_config.deleted_threshold: value 0.2 invalid, must be 1.0 or larger]"}"
Steps to Reproduce
- Create a collection with deleted_threshold = 0.2 via grpc ( I did this as part of the migrate module )
Expected Behavior
0.2 is a valid value for the deleted threshold and migration should run successfully
Possible Solution
Revert to the old grpc validation ( revert PR #5650 )
Context (Environment)
Same migration goes through successfully using http.
GPRC validation seems to be incorrect in the latest release.
OptimizersConfigDiff.deleted_threshold", "range(min = 1.0)"), makes it so that the min val of deleted threshold is 1, however in reality the value is between 0 -> 1. This is confirmed by the code in the commit before the grpc validation change.Current Behavior
Was discovered when I tried to migrate using the
qdrant_client.migrate.migrate modulewith a grpc client as target and got the following errorSteps to Reproduce
Expected Behavior
0.2 is a valid value for the deleted threshold and migration should run successfully
Possible Solution
Revert to the old grpc validation ( revert PR #5650 )
Context (Environment)
Same migration goes through successfully using http.