add basic openapi test

coszio · coszio · commit c89ca7b7d4df · 2025-04-04T11:16:24.000-03:00
diff --git a/lib/collection/src/operations/verification/query.rs b/lib/collection/src/operations/verification/query.rs
@@ -28,7 +28,7 @@ impl Query {
                         format!(
                             "Index required but not found for \"{key}\" of one of the following types: [{possible_schemas_str}]",
                         ),
-                        "Create an index for this key or use a different expression.",
+                        "Create an index for this key or use a different formula expression.",
                     ));
                 }
             }
diff --git a/tests/openapi/test_strictmode.py b/tests/openapi/test_strictmode.py
@@ -1323,6 +1323,47 @@ def search_request(condition_size: int = 2):
     assert not search_fail.ok
 
 
+def test_strict_mode_formula_expression(collection_name):
+
+    def query_request():
+        expression = {
+            "sum": [
+                "discount_price",
+                "$score",
+            ]
+        }
+
+        return request_with_validation(
+            api='/collections/{collection_name}/points/query',
+            method="POST",
+            path_params={'collection_name': collection_name},
+            body={
+                "prefetch": {
+                    "query": [0.1, 0.2, 0.3, 0.4],
+                },
+                "query": {
+                    "formula": expression,
+                    "defaults": { "discount_price": 0 } # Even with default, it should still be restricted
+                }
+            }
+        )
+    # No restriction, query succeeds
+    query_ok = query_request()
+    assert query_ok.ok
+
+    set_strict_mode(collection_name, {
+        "enabled": True,
+        "condition_max_size": 1000000,  # Disabled
+        "unindexed_filtering_retrieve": False,
+    })
+
+    # Now it should fail
+    query_fail = query_request()
+    assert not query_fail.ok
+    assert "discount_price" in query_fail.json()['status']['error']
+    assert "formula expression" in query_fail.json()['status']['error']
+
+
 def test_strict_mode_read_rate_limiting_small_replenish(collection_name):
     """
     If our read rate limit capacity is larger, test that when exhausting it
@@ -1418,4 +1459,4 @@ def test_strict_mode_unset_rate_limiting_config(collection_name):
     assert new_strict_mode_config['enabled']
     assert new_strict_mode_config['read_rate_limit'] == 2
     # assert write rate limit is not unset because it is currently not supported
-    assert new_strict_mode_config['write_rate_limit'] == 1
+    assert new_strict_mode_config['write_rate_limit'] == 1

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ impl Query {`
`28`	`28`	`format!(`
`29`	`29`	`"Index required but not found for \"{key}\" of one of the following types: [{possible_schemas_str}]",`
`30`	`30`	`),`
`31`		`- "Create an index for this key or use a different expression.",`
	`31`	`+ "Create an index for this key or use a different formula expression.",`
`32`	`32`	`));`
`33`	`33`	`}`
`34`	`34`	`}`