better test

agourlay · agourlay · commit c0093d0aa337 · 2025-05-16T10:50:37.000+02:00
diff --git a/tests/openapi/test_strictmode.py b/tests/openapi/test_strictmode.py
@@ -239,24 +239,29 @@ def search_request_with_filter():
             }
         )
 
+    # works without strict mode
     search_request_with_filter().raise_for_status()
 
+    # enable strict mode `unindexed_filtering_retrieve`
     set_strict_mode(collection_name, {
         "enabled": True,
         "unindexed_filtering_retrieve": True,
     })
 
+    # still works
     search_request_with_filter().raise_for_status()
 
+    # toggle `unindexed_filtering_retrieve`
     set_strict_mode(collection_name, {
         "unindexed_filtering_retrieve": False,
     })
 
+    # search fail because no payload index
     search_fail = search_request_with_filter()
-
     assert "count" in search_fail.json()['status']['error']
     assert not search_fail.ok
 
+    # create payload index
     request_with_validation(
         api='/collections/{collection_name}/index',
         method="PUT",
@@ -266,16 +271,16 @@ def search_request_with_filter():
             "field_name": "count",
             "field_schema": {
                 "type": "integer",
-                "lookup": False,
+                "lookup": True,
                 "range": True,
             }
         }
     ).raise_for_status()
 
-    # the integer index does not support `lookup` on our match condition
-    assert "count" in search_fail.json()['status']['error']
-    assert not search_fail.ok
+    # works now by leveraging index
+    search_request_with_filter().raise_for_status()
 
+    # remove lookup capacity on index
     request_with_validation(
         api='/collections/{collection_name}/index',
         method="PUT",
@@ -285,14 +290,16 @@ def search_request_with_filter():
             "field_name": "count",
             "field_schema": {
                 "type": "integer",
-                "lookup": True,
+                "lookup": False,
                 "range": True,
             }
         }
     ).raise_for_status()
-    
-    # We created an index with `lookup` on this field so it should work now
-    search_request_with_filter().raise_for_status()
+
+    # fails because the integer index does not support `lookup` for our match condition
+    search_fail = search_request_with_filter()
+    assert "count" in search_fail.json()['status']['error']
+    assert not search_fail.ok
  
 
 def test_strict_mode_unindexed_filter_write_validation(collection_name):
