clippy

coszio · coszio · commit 9a3ccc97170f · 2025-04-03T14:44:43.000-03:00
diff --git a/lib/collection/src/problems/unindexed_field.rs b/lib/collection/src/problems/unindexed_field.rs
@@ -402,7 +402,7 @@ impl<'a> Extractor<'a> {
         }
     }
 
-    fn needs_index(&self, key: &JsonPath, inferred: &Vec<PayloadFieldSchema>) -> bool {
+    fn needs_index(&self, key: &JsonPath, inferred: &[PayloadFieldSchema]) -> bool {
         match self.payload_schema.get(key) {
             Some(index_info) => {
                 let index_info_kind = index_info.kind();
@@ -456,7 +456,7 @@ impl<'a> Extractor<'a> {
                 }
             }
             ExpressionInternal::Condition(condition) => {
-                self.update_from_condition(None, &*condition);
+                self.update_from_condition(None, condition);
                 return;
             }
             ExpressionInternal::GeoDistance { origin: _, to } => {
@@ -470,52 +470,52 @@ impl<'a> Extractor<'a> {
             }
             ExpressionInternal::Mult(expression_internals) => {
                 for expr in expression_internals {
-                    self.update_from_expression(&*expr);
+                    self.update_from_expression(expr);
                 }
                 return;
             }
             ExpressionInternal::Sum(expression_internals) => {
                 for expr in expression_internals {
-                    self.update_from_expression(&*expr);
+                    self.update_from_expression(expr);
                 }
                 return;
             }
             ExpressionInternal::Neg(expression_internal) => {
-                self.update_from_expression(&*expression_internal);
+                self.update_from_expression(expression_internal);
                 return;
             }
             ExpressionInternal::Div {
                 left,
                 right,
                 by_zero_default: _,
             } => {
-                self.update_from_expression(&*left);
-                self.update_from_expression(&*right);
+                self.update_from_expression(left);
+                self.update_from_expression(right);
                 return;
             }
             ExpressionInternal::Sqrt(expression_internal) => {
-                self.update_from_expression(&*expression_internal);
+                self.update_from_expression(expression_internal);
                 return;
             }
             ExpressionInternal::Pow { base, exponent } => {
-                self.update_from_expression(&*base);
-                self.update_from_expression(&*exponent);
+                self.update_from_expression(base);
+                self.update_from_expression(exponent);
                 return;
             }
             ExpressionInternal::Exp(expression_internal) => {
-                self.update_from_expression(&*expression_internal);
+                self.update_from_expression(expression_internal);
                 return;
             }
             ExpressionInternal::Log10(expression_internal) => {
-                self.update_from_expression(&*expression_internal);
+                self.update_from_expression(expression_internal);
                 return;
             }
             ExpressionInternal::Ln(expression_internal) => {
-                self.update_from_expression(&*expression_internal);
+                self.update_from_expression(expression_internal);
                 return;
             }
             ExpressionInternal::Abs(expression_internal) => {
-                self.update_from_expression(&*expression_internal);
+                self.update_from_expression(expression_internal);
                 return;
             }
             ExpressionInternal::Decay {
@@ -525,8 +525,10 @@ impl<'a> Extractor<'a> {
                 midpoint: _,
                 scale: _,
             } => {
-                self.update_from_expression(&*x);
-                target.as_ref().map(|t| self.update_from_expression(&*t));
+                self.update_from_expression(x);
+                if let Some(t) = target.as_ref() {
+                    self.update_from_expression(t)
+                };
                 return;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ impl<'a> Extractor<'a> {`
`402`	`402`	`}`
`403`	`403`	`}`
`404`	`404`
`405`		`- fn needs_index(&self, key: &JsonPath, inferred: &Vec<PayloadFieldSchema>) -> bool {`
	`405`	`+ fn needs_index(&self, key: &JsonPath, inferred: &[PayloadFieldSchema]) -> bool {`
`406`	`406`	`match self.payload_schema.get(key) {`
`407`	`407`	`Some(index_info) => {`
`408`	`408`	`let index_info_kind = index_info.kind();`
`@@ -456,7 +456,7 @@ impl<'a> Extractor<'a> {`
`456`	`456`	`}`
`457`	`457`	`}`
`458`	`458`	`ExpressionInternal::Condition(condition) => {`
`459`		`- self.update_from_condition(None, &*condition);`
	`459`	`+ self.update_from_condition(None, condition);`
`460`	`460`	`return;`
`461`	`461`	`}`
`462`	`462`	`ExpressionInternal::GeoDistance { origin: _, to } => {`
`@@ -470,52 +470,52 @@ impl<'a> Extractor<'a> {`
`470`	`470`	`}`
`471`	`471`	`ExpressionInternal::Mult(expression_internals) => {`
`472`	`472`	`for expr in expression_internals {`
`473`		`- self.update_from_expression(&*expr);`
	`473`	`+ self.update_from_expression(expr);`
`474`	`474`	`}`
`475`	`475`	`return;`
`476`	`476`	`}`
`477`	`477`	`ExpressionInternal::Sum(expression_internals) => {`
`478`	`478`	`for expr in expression_internals {`
`479`		`- self.update_from_expression(&*expr);`
	`479`	`+ self.update_from_expression(expr);`
`480`	`480`	`}`
`481`	`481`	`return;`
`482`	`482`	`}`
`483`	`483`	`ExpressionInternal::Neg(expression_internal) => {`
`484`		`- self.update_from_expression(&*expression_internal);`
	`484`	`+ self.update_from_expression(expression_internal);`
`485`	`485`	`return;`
`486`	`486`	`}`
`487`	`487`	`ExpressionInternal::Div {`
`488`	`488`	`left,`
`489`	`489`	`right,`
`490`	`490`	`by_zero_default: _,`
`491`	`491`	`} => {`
`492`		`- self.update_from_expression(&*left);`
`493`		`- self.update_from_expression(&*right);`
	`492`	`+ self.update_from_expression(left);`
	`493`	`+ self.update_from_expression(right);`
`494`	`494`	`return;`
`495`	`495`	`}`
`496`	`496`	`ExpressionInternal::Sqrt(expression_internal) => {`
`497`		`- self.update_from_expression(&*expression_internal);`
	`497`	`+ self.update_from_expression(expression_internal);`
`498`	`498`	`return;`
`499`	`499`	`}`
`500`	`500`	`ExpressionInternal::Pow { base, exponent } => {`
`501`		`- self.update_from_expression(&*base);`
`502`		`- self.update_from_expression(&*exponent);`
	`501`	`+ self.update_from_expression(base);`
	`502`	`+ self.update_from_expression(exponent);`
`503`	`503`	`return;`
`504`	`504`	`}`
`505`	`505`	`ExpressionInternal::Exp(expression_internal) => {`
`506`		`- self.update_from_expression(&*expression_internal);`
	`506`	`+ self.update_from_expression(expression_internal);`
`507`	`507`	`return;`
`508`	`508`	`}`
`509`	`509`	`ExpressionInternal::Log10(expression_internal) => {`
`510`		`- self.update_from_expression(&*expression_internal);`
	`510`	`+ self.update_from_expression(expression_internal);`
`511`	`511`	`return;`
`512`	`512`	`}`
`513`	`513`	`ExpressionInternal::Ln(expression_internal) => {`
`514`		`- self.update_from_expression(&*expression_internal);`
	`514`	`+ self.update_from_expression(expression_internal);`
`515`	`515`	`return;`
`516`	`516`	`}`
`517`	`517`	`ExpressionInternal::Abs(expression_internal) => {`
`518`		`- self.update_from_expression(&*expression_internal);`
	`518`	`+ self.update_from_expression(expression_internal);`
`519`	`519`	`return;`
`520`	`520`	`}`
`521`	`521`	`ExpressionInternal::Decay {`
`@@ -525,8 +525,10 @@ impl<'a> Extractor<'a> {`
`525`	`525`	`midpoint: _,`
`526`	`526`	`scale: _,`
`527`	`527`	`} => {`
`528`		`- self.update_from_expression(&*x);`
`529`		`- target.as_ref().map(\|t\| self.update_from_expression(&*t));`
	`528`	`+ self.update_from_expression(x);`
	`529`	`+ if let Some(t) = target.as_ref() {`
	`530`	`+ self.update_from_expression(t)`
	`531`	`+ };`
`530`	`532`	`return;`
`531`	`533`	`}`
`532`	`534`	`}`