remove payload_m check for now - tackle in next multitenancy PR

agourlay · agourlay · commit 8e63b7747a4e · 2025-05-02T12:57:51.000+02:00
diff --git a/lib/collection/src/operations/verification/query.rs b/lib/collection/src/operations/verification/query.rs
@@ -69,12 +69,11 @@ impl Query {
                         .and_then(|param| param.hnsw_config.as_ref());
 
                     let vector_hnsw_m = vector_hnsw_config.and_then(|hnsw| hnsw.m);
-                    let vector_hnsw_payload_m = vector_hnsw_config.and_then(|hnsw| hnsw.payload_m);
-
-                    if vector_hnsw_m == Some(0) || vector_hnsw_payload_m == Some(0) {
+                    // TODO(strict-mode) check also payload_m if if there is a filter by tenant/principal
+                    if vector_hnsw_m == Some(0) {
                         return Err(CollectionError::strict_mode(
                             format!(
-                                "Fullscan forbidden on '{using}' – vector indexing is disabled (m = 0 or payload_m = 0)"
+                                "Fullscan forbidden on '{using}' – vector indexing is disabled (hnsw_config.m = 0)"
                             ),
                             "Enable vector indexing or use a prefetch query before rescoring",
                         ));
diff --git a/tests/openapi/test_strictmode.py b/tests/openapi/test_strictmode.py
@@ -1861,7 +1861,7 @@ def test_strict_mode_full_scan(full_collection_name):
         }
     )
     assert not response.ok
-    assert "Fullscan forbidden on 'dense-multi' – vector indexing is disabled (m = 0 or payload_m = 0). Help: Enable vector indexing or use a prefetch query before rescoring" in response.json()['status']['error']
+    assert "Fullscan forbidden on 'dense-multi' – vector indexing is disabled (hnsw_config.m = 0). Help: Enable vector indexing or use a prefetch query before rescoring" in response.json()['status']['error']
 
     # sparse vector still works
     response = request_with_validation(
@@ -1915,4 +1915,4 @@ def test_strict_mode_full_scan(full_collection_name):
         }
     )
     assert not response.ok
-    assert "Fullscan forbidden on 'dense-multi' – vector indexing is disabled (m = 0 or payload_m = 0). Help: Enable vector indexing or use a prefetch query before rescoring" in response.json()['status']['error']
+    assert "Fullscan forbidden on 'dense-multi' – vector indexing is disabled (hnsw_config.m = 0). Help: Enable vector indexing or use a prefetch query before rescoring" in response.json()['status']['error']

Original file line number	Diff line number	Diff line change
`@@ -1861,7 +1861,7 @@ def test_strict_mode_full_scan(full_collection_name):`
`1861`	`1861`	`}`
`1862`	`1862`	`)`
`1863`	`1863`	`assert not response.ok`
`1864`		`- assert "Fullscan forbidden on 'dense-multi' – vector indexing is disabled (m = 0 or payload_m = 0). Help: Enable vector indexing or use a prefetch query before rescoring" in response.json()['status']['error']`
	`1864`	`+ assert "Fullscan forbidden on 'dense-multi' – vector indexing is disabled (hnsw_config.m = 0). Help: Enable vector indexing or use a prefetch query before rescoring" in response.json()['status']['error']`
`1865`	`1865`
`1866`	`1866`	`# sparse vector still works`
`1867`	`1867`	`response = request_with_validation(`
`@@ -1915,4 +1915,4 @@ def test_strict_mode_full_scan(full_collection_name):`
`1915`	`1915`	`}`
`1916`	`1916`	`)`
`1917`	`1917`	`assert not response.ok`
`1918`		`- assert "Fullscan forbidden on 'dense-multi' – vector indexing is disabled (m = 0 or payload_m = 0). Help: Enable vector indexing or use a prefetch query before rescoring" in response.json()['status']['error']`
	`1918`	`+ assert "Fullscan forbidden on 'dense-multi' – vector indexing is disabled (hnsw_config.m = 0). Help: Enable vector indexing or use a prefetch query before rescoring" in response.json()['status']['error']`