fixup! Add edge crate

ffuugoo · ffuugoo · commit 621c9409ec04 · 2025-09-25T11:33:04.000+02:00
Add placeholder `MultiVectorConfig::is_compatible` check
diff --git a/lib/segment/src/types.rs b/lib/segment/src/types.rs
@@ -1419,13 +1419,13 @@ impl SegmentConfig {
             payload_storage_type: _,
         } = self;
 
-        let is_vector_config_compatible = is_compatible(
+        let is_vector_config_compatible = is_map_compatible(
             &self.vector_data,
             &other.vector_data,
             VectorDataConfig::is_compatible,
         );
 
-        let is_sparse_vector_config_compatible = is_compatible(
+        let is_sparse_vector_config_compatible = is_map_compatible(
             &self.sparse_vector_data,
             &other.sparse_vector_data,
             SparseVectorDataConfig::is_compatible,
@@ -1435,7 +1435,7 @@ impl SegmentConfig {
     }
 }
 
-fn is_compatible<V, C, F>(this: &HashMap<V, C>, other: &HashMap<V, C>, check: F) -> bool
+fn is_map_compatible<V, C, F>(this: &HashMap<V, C>, other: &HashMap<V, C>, check: F) -> bool
 where
     V: Eq + Hash,
     F: Fn(&C, &C) -> bool,
@@ -1518,6 +1518,17 @@ pub struct MultiVectorConfig {
     pub comparator: MultiVectorComparator,
 }
 
+impl MultiVectorConfig {
+    fn is_compatible(&self, other: &Self) -> bool {
+        // TODO: Does comparator have to be same for two segments to be compatible? 🤔
+
+        // Assert multi-vector config fields
+        let Self { comparator: _ } = self;
+
+        self.comparator == other.comparator // TODO: 🤔
+    }
+}
+
 #[derive(
     Debug, Default, Deserialize, Serialize, JsonSchema, Anonymize, Eq, PartialEq, Copy, Clone, Hash,
 )]
@@ -1596,8 +1607,19 @@ impl VectorDataConfig {
 
         self.size == other.size
             && self.distance == other.distance
-            && self.multivector_config == other.multivector_config // TODO: 🤔
             && self.datatype == other.datatype // TODO: 🤔
+            && is_opt_compatible(
+                self.multivector_config.as_ref(),
+                other.multivector_config.as_ref(),
+                MultiVectorConfig::is_compatible,
+            )
+    }
+}
+
+fn is_opt_compatible<T, F: Fn(T, T) -> bool>(this: Option<T>, other: Option<T>, check: F) -> bool {
+    match (this, other) {
+        (Some(this), Some(other)) => check(this, other),
+        _ => false,
     }
 }
 
