File tree Expand file tree Collapse file tree
lib/shard/src/segment_holder Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -969,7 +969,7 @@ impl SegmentHolder {
969969 log:: trace!( "Applying function on all proxied shard segments" ) ;
970970 let mut result = Ok ( ( ) ) ;
971971 let mut unproxied_segment_ids = Vec :: with_capacity ( proxies. len ( ) ) ;
972- // Reverse to unproxify first non-appenable segments
972+ // Reverse to unproxify first non-appendable segments
973973 proxies. reverse ( ) ;
974974 for ( segment_id, proxy_segment) in & proxies {
975975 // Get segment to snapshot
@@ -1003,8 +1003,8 @@ impl SegmentHolder {
10031003 // Make sure to keep at least one proxy segment to maintain access to the points in the shared write segment.
10041004 // The last proxy and the shared write segment will be promoted into the segment_holder atomically
10051005 // by `Self::unproxy_all_segments` afterwards to maintain the read consistency.
1006- let is_last_proxy = unproxied_segment_ids . len ( ) >= proxies . len ( ) - 1 ;
1007- if !is_last_proxy {
1006+ let remaining = proxies . len ( ) - unproxied_segment_ids . len ( ) ;
1007+ if remaining > 1 {
10081008 match Self :: try_unproxy_segment ( segments_lock, * segment_id, proxy_segment. clone ( ) ) {
10091009 Ok ( lock) => {
10101010 segments_lock = lock;
You can’t perform that action at this time.
0 commit comments