Improve error messages for decay midpoint and scale validation

coszio · coszio · commit 1b3e72dcebfe · 2025-03-12T16:07:16.000-03:00
diff --git a/lib/segment/src/index/query_optimization/rescore_formula/parsed_formula.rs b/lib/segment/src/index/query_optimization/rescore_formula/parsed_formula.rs
@@ -164,15 +164,15 @@ impl ParsedExpression {
         let scale = scale.unwrap_or(DEFAULT_DECAY_SCALE);
 
         if midpoint <= 0.0 || midpoint >= 1.0 {
-            return Err(OperationError::validation_error(
-                "Decay midpoint should be between 0.0 and 1.0, not inclusive.",
-            ));
+            return Err(OperationError::validation_error(format!(
+                "Decay midpoint should be between 0.0 and 1.0 (exclusive), got {midpoint}."
+            )));
         }
 
         if scale <= 0.0 {
-            return Err(OperationError::validation_error(
-                "Decay scale should be non-zero positive.",
-            ));
+            return Err(OperationError::validation_error(format!(
+                "Decay scale should be non-zero positive, got {scale}."
+            )));
         }
 
         let lambda = match kind {
