Skip to content

Add version check on client init#61

Merged
tellet-q merged 4 commits intomasterfrom
check-version-on-init
Jan 2, 2025
Merged

Add version check on client init#61
tellet-q merged 4 commits intomasterfrom
check-version-on-init

Conversation

@tellet-q
Copy link
Copy Markdown
Contributor

Send request to fetch server version during client init and compare with client version.

Introduce an optional checkCompatibility param (true by default). If it is true -> check versions during client init and generate a warning if versions are not compatible. Compatible versions are the ones that differ by one, i.e client version 1.6.x is compatible with server versions 1.5.x and 1.7.x but not 1.4.x or 1.8.x.

@tellet-q tellet-q requested a review from Anush008 December 20, 2024 12:35
Copy link
Copy Markdown
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Comment thread src/main/java/io/qdrant/client/QdrantGrpcClient.java Outdated
@tellet-q tellet-q requested a review from Anush008 December 20, 2024 14:44
Comment thread src/main/java/io/qdrant/client/VersionsCompatibilityChecker.java
Comment thread src/main/java/io/qdrant/client/VersionsCompatibilityChecker.java Outdated
@tellet-q tellet-q requested a review from Anush008 January 2, 2025 08:13
Copy link
Copy Markdown
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tellet-q tellet-q merged commit 82584c0 into master Jan 2, 2025
@tellet-q tellet-q deleted the check-version-on-init branch January 2, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants