Repo maintenance #6
Conversation
jenniferboedker
left a comment
jenniferboedker
left a comment
There was a problem hiding this comment.
You need to add this
# Remove existing snapshot tags which are not supposed to be present
- name: Remove snapshot tags
run: mvn versions:set -DremoveSnapshot
# Set the SNAPSHOT for this build and deployment
- name: Set version in Maven project
run: mvn versions:set -DnewVersion='${project.version}-SNAPSHOT'
to nexus-publish.yml instead of nexus-publish-release.yml. The later one should also be deleted.
Furthermore, the release workflow is missing and you need to add caching to the build_package.yml (See https://github.com/qbicsoftware/data-model-lib/pull/286/files)
I am also not sure if you really need the version increase here, it seems to me that the parent-pom was not removed.
Co-authored-by: jnnfr <[email protected]>
Co-authored-by: jnnfr <[email protected]>
Co-authored-by: jnnfr <[email protected]>
|
Since you are not changing the actual code for this repo I think this should be merged to master, also: there is still the comment about the pom and the new version in the CL. Why did you add it here? |
jenniferboedker
left a comment
jenniferboedker
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments!
I have some more (sorry!): the workflow structure does not look like in the template (not all ymls are there, e.g also check outside the workflow folder of the template). I am happy to have a quick call to clarify whats missing.
|
I jsut also found the "how to run" and "how to use" sections are missing. I think you just need to update the section titles since the content is already there |
Co-authored-by: Sven F. <[email protected]>
jenniferboedker
left a comment
jenniferboedker
left a comment
There was a problem hiding this comment.
some minor things left then you are good to go :)
Co-authored-by: jnnfr <[email protected]>
I assume code QL will work once this is on dev?