Skip to content

Conversation

@sven1103
Copy link
Contributor

No description provided.

Copy link
Contributor

@jenniferboedker jenniferboedker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
NIT: maybe update the CHANGELOG?

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #2 into master will decrease coverage by 44.91%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #2       +/-   ##
==========================================
- Coverage   44.91%   0.00%   -44.92%     
==========================================
  Files          34      34               
  Lines        1071    1075        +4     
  Branches      237     237               
==========================================
- Hits          481       0      -481     
- Misses        513    1075      +562     
+ Partials       77       0       -77     
Impacted Files Coverage Δ
...rc/main/java/life/qbic/xml/study/Qcategorical.java 0.00% <0.00%> (-65.58%) ⬇️
src/main/java/life/qbic/xml/study/Qcontinuous.java 0.00% <0.00%> (-61.43%) ⬇️
src/main/java/life/qbic/xml/study/Qexperiment.java 0.00% <0.00%> (-100.00%) ⬇️
...in/java/life/qbic/xml/properties/PropertyType.java 0.00% <0.00%> (-100.00%) ⬇️
src/main/java/life/qbic/xml/properties/Unit.java 0.00% <0.00%> (-95.92%) ⬇️
.../main/java/life/qbic/xml/manager/XMLValidator.java 0.00% <0.00%> (-92.86%) ⬇️
...c/main/java/life/qbic/xml/study/ObjectFactory.java 0.00% <0.00%> (-90.00%) ⬇️
...ain/java/life/qbic/xml/manager/StudyXMLParser.java 0.00% <0.00%> (-80.85%) ⬇️
src/main/java/life/qbic/xml/study/Qfactors.java 0.00% <0.00%> (-45.29%) ⬇️
src/main/java/life/qbic/xml/study/Qproperty.java 0.00% <0.00%> (-43.86%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c564e1...b0ea7f2. Read the comment docs.

@sven1103 sven1103 merged commit c9c7148 into master Sep 23, 2020
@sven1103 sven1103 deleted the release/1.6.0 branch September 23, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants