Add support for pod5 files generated via dorado basecaller #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 3, 2023 13:19
…ado-basecalled-nanopore-structure' into feature/dm-1003-dorado-basecalled-nanopore-structure
...in/groovy/life/qbic/datamodel/instruments/OxfordNanoporeInstrumentOutputDoradoMinimal.groovy
Outdated
Show resolved
Hide resolved
...ain/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5SkipFolder.groovy
Outdated
Show resolved
Hide resolved
...in/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Fast5SkipFolder.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/life/qbic/datamodel/datasets/OxfordNanoporeMeasurement.groovy
Show resolved
Hide resolved
wow-such-code
requested changes
Nov 3, 2023
Member
wow-such-code
left a comment
wow-such-code
left a comment
There was a problem hiding this comment.
a few questions/nitpicks, but seems sensible so far!
wow-such-code
approved these changes
Nov 3, 2023
Steffengreiner
deleted the
feature/dm-1003-dorado-basecalled-nanopore-structure
branch
This was referenced Nov 3, 2023
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Apparently the new Nanopore machines generate pod5 files instead of fast5 files dependent on the employed basecaller. Since the partner labs are updating their machines it's necessary to account for the newly valid minimal filetree structure