Introduce minimal Schema for nanopore registration (#350) #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce Optional Files and Folders for nanopore registration with schema and json examples + tests * Adapt OxfordNanoporeExperiment and Tests to account for optional folders and file generation instead of throwing errors * Remove barcode_alignment from the list of required files in the minimal expected datastructure * Introduce new schema version so minContains can be employed to check for minimum number of files * Include example of measurementname in minimal schema * Fix typo in Optional File description Co-authored-by: Tobias Koch <[email protected]> * Remove outdated comment and switch static final * Introduce NanoporeFile and NanoporeFolder Enums and dedicated isFile and isFolder check methods --------- Co-authored-by: Tobias Koch <[email protected]>
KochTobi
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 2.25.0
Co-authored-by: Tobias Koch [email protected]
Remove outdated comment and switch static final
Introduce NanoporeFile and NanoporeFolder Enums and dedicated isFile and isFolder check methods
Co-authored-by: Tobias Koch [email protected]