Skip to content

Conversation

@Steffengreiner
Copy link
Contributor

What was changed
Introduces new nanopore structure v4

Steffengreiner and others added 2 commits December 12, 2022 13:44
…econd basecalling (#344)

* WIP New nanopore schema accounting for second basecalling folder

* Finalize nanopore schema accounting for second basecalling folder

* Add minItems to ensure that all files are provided

* Provide datastructure model in readme for basecalling folder

* apply review suggestion

Co-authored-by: wow-such-code <[email protected]>

* Update v3 Readme

Co-authored-by: wow-such-code <[email protected]>

* Update v3 Readme

Co-authored-by: wow-such-code <[email protected]>

* Provide datastructure model in readme for basecalling folder

Co-authored-by: wow-such-code <[email protected]>
@Steffengreiner Steffengreiner requested a review from a team as a code owner December 12, 2022 13:56
"$id": "http://qbic.life/nanopore-instrument-output.schema.json",
"title": "Nanopore Instrument Output",
"description": "Describes in which form Nanopore data is received from the lab.",
"description": "Describes in which form PromethION/MinION sequenced sequenced Nanopore is received from the Microbiology lab.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Describes in which form PromethION/MinION sequenced sequenced Nanopore is received from the Microbiology lab.",
"description": "Describes in which form PromethION/MinION sequenced Nanopore is received from the Microbiology lab.",

"$id": "http://qbic.life/nanopore-instrument-output_v2.schema.json",
"title": "Nanopore Instrument Output V2",
"description": "Describes in which form Nanopore data is received from the lab.",
"description": "Describes in which form PromethION/MinION sequenced sequenced Nanopore data is received from the medical genetics lab. Accounts for 'other reports' folder created by the lab",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Describes in which form PromethION/MinION sequenced sequenced Nanopore data is received from the medical genetics lab. Accounts for 'other reports' folder created by the lab",
"description": "Describes in which form PromethION/MinION sequenced Nanopore data is received from the medical genetics lab. Accounts for 'other reports' folder created by the lab",

"$id": "http://qbic.life/nanopore-instrument-output_v3.schema.json",
"title": "Nanopore Instrument Output V3",
"description": "Describes in which form Nanopore data is received from the lab.",
"description": "Describes in which form PromethION/MinION sequenced sequenced Nanopore data is received from the medical genetics lab. Accounts for the adapted 'other_reports' folder structure provided by the lab",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Describes in which form PromethION/MinION sequenced sequenced Nanopore data is received from the medical genetics lab. Accounts for the adapted 'other_reports' folder structure provided by the lab",
"description": "Describes in which form PromethION/MinION sequenced Nanopore data is received from the medical genetics lab. Accounts for the adapted 'other_reports' folder structure provided by the lab",

Copy link
Member

@wow-such-code wow-such-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Steffengreiner Steffengreiner merged commit 322b212 into master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants