Introduce new Nanopore schema to account for files generated due to second basecalling #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steffengreiner
changed the title
src/main/groovy/life/qbic/datamodel/instruments/OxfordNanoporeInstrumentOutputV4.groovy
Outdated
Show resolved
Hide resolved
src/main/resources/schemas/nanopore-instrument-output_v2.schema.json
Outdated
Show resolved
Hide resolved
src/main/resources/schemas/nanopore-instrument-output_v3.schema.json
Outdated
Show resolved
Hide resolved
wow-such-code
previously approved these changes
Dec 12, 2022
Member
wow-such-code
left a comment
wow-such-code
left a comment
There was a problem hiding this comment.
nice work! especially including all of the tests for new file types
Co-authored-by: wow-such-code <[email protected]>
Co-authored-by: wow-such-code <[email protected]>
wow-such-code
requested changes
Dec 12, 2022
Member
wow-such-code
left a comment
wow-such-code
left a comment
There was a problem hiding this comment.
oops, forgot about my suggestions. also please increase snapshot version, we forgot that after the last release
Co-authored-by: wow-such-code <[email protected]>
Steffengreiner
deleted the
feature/dm-583-introduce-new-nanopore-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR introduces a new nanopore schema to account for files generated during the performance of a manual higher accuracy basecalling after the initial fast basecall.
More information
Addresses DM-583