Remove automatic replacement of hyphens with underscores in Project Space naming #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1103
pushed a commit
that referenced
this pull request
Aug 26, 2022
* increase snapshot to 2.20.0 * Adjust Nf-core pipeline result to account for sarekv3 file structure * Remove replacement of hyphens with underscores in project spaces (#326) Co-authored-by: wow-such-code <[email protected]>
Steffengreiner
added a commit
that referenced
this pull request
Oct 13, 2022
* increase snapshot to 2.20.0 * Adjust Nf-core pipeline result to account for sarekv3 file structure * Remove replacement of hyphens with underscores in project spaces (#326) * add digiwest property tpes * Support nanopore data structure v3 (#328) * add new version of valid nanopore structure * implement additional v3 changes * Update schema and test to current file structure Co-authored-by: Steffengreiner <[email protected]> * Fix Nanopore Schema V3 naming and streamline children of other report definition * Adapt schema and add test case for mibi datastructure Co-authored-by: wow-such-code <[email protected]>
Steffengreiner
added a commit
that referenced
this pull request
Oct 13, 2022
* Prepare Version 2.20.0 (#325) * increase snapshot to 2.20.0 * Adjust Nf-core pipeline result to account for sarekv3 file structure * Remove replacement of hyphens with underscores in project spaces (#326) Co-authored-by: wow-such-code <[email protected]> * Update version to 2.20.0 (#327) * Set version to 2.20.0 * remove unnessary whitespace Co-authored-by: Steffengreiner <[email protected]> * Release/2.21.0 (#331) * increase snapshot to 2.20.0 * Adjust Nf-core pipeline result to account for sarekv3 file structure * Remove replacement of hyphens with underscores in project spaces (#326) * add digiwest property tpes * Support nanopore data structure v3 (#328) * add new version of valid nanopore structure * implement additional v3 changes * Update schema and test to current file structure Co-authored-by: Steffengreiner <[email protected]> * Fix Nanopore Schema V3 naming and streamline children of other report definition * Adapt schema and add test case for mibi datastructure Co-authored-by: wow-such-code <[email protected]> * Set version to 2.21.0 (#332) Co-authored-by: wow-such-code <[email protected]> Co-authored-by: Johnny Q5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR allows project spaces with hyphens in their name by removing their automatic replacement with underscores in the project space class
Additional Information
See DM-481 for more information