Release/1.10.0 #75
Merged
Release/1.10.0 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync Release 1.9.0
Sync with hotfix 1.9.1
* Hotfix 1.9.1 (#66) * Fix RST syntax error * Remove orphaned print statement * Update CL * Bump version 1.9.1 -> 1.9.2 Co-authored-by: Steffengreiner <[email protected]>
The summary file is now searched within the summary folder
Sync with hotfix 1.9.3
Member
Author
Steffengreiner
requested changes
Sep 13, 2021
Contributor
Steffengreiner
left a comment
Steffengreiner
left a comment
There was a problem hiding this comment.
Heya @wow-such-code, thanks for preparing the release! 👍
I found some minor issues that should be addressed before it's ready for merging.
- Instead of bumping the version by hand, i'd suggest using the qube bump-version functionality to keep the version in the qube files(such as qube.yml and qube.cfg) also in sync.
- This is a Nit but i'd appreciate it if the changelog date matches the release date
Co-authored-by: Steffengreiner <[email protected]>
Steffengreiner
requested changes
Sep 13, 2021
Contributor
Steffengreiner
left a comment
Steffengreiner
left a comment
There was a problem hiding this comment.
Nice Qube Bump-Version, however it duplicated an entry in the changelog. 🙈
CHANGELOG.rst
Outdated
Comment on lines
62
to
73
| 1.10.0 (2021-09-13) | ||
| ------------------- | ||
|
|
||
| **Added** | ||
|
|
||
| **Fixed** | ||
|
|
||
| **Dependencies** | ||
|
|
||
| **Deprecated** | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
I guess qube duplicated the Changelog entry? 😕
Suggested change
| 1.10.0 (2021-09-13) | |
| ------------------- | |
| **Added** | |
| **Fixed** | |
| **Dependencies** | |
| **Deprecated** |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.