Skip to content

Conversation

@Steffengreiner
Copy link
Contributor

@Steffengreiner Steffengreiner commented Jan 31, 2023

Description of changes
The Nanoporeparser will after all previously defined schemas failed check if the minimum required filestructure was provided and if not now output the failling schemas with information about failure correctly

Additional context
POM.XML needs to be adapted as soon as the data-model-lib PR is approved, which is also why this PR currently fails
Additionally as mentioned in the data-model-lib PR ALL the previous schemas are now technically useless and can be removed since they also require the minimum amount of files present

@Steffengreiner Steffengreiner marked this pull request as ready for review February 13, 2023 14:47
@Steffengreiner Steffengreiner requested a review from a team as a code owner February 13, 2023 14:47
@KochTobi KochTobi self-requested a review February 13, 2023 15:22
Copy link
Contributor

@KochTobi KochTobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Steffengreiner Steffengreiner merged commit 2d9a934 into development Feb 13, 2023
@Steffengreiner Steffengreiner deleted the feature/dm-670-parse-minimal-nanopore-structure branch February 13, 2023 15:24
Steffengreiner added a commit that referenced this pull request Feb 13, 2023
Adapt Nanoporeparser to check if minimal required files were provided (#120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants